On Sat, Mar 03, 2007 at 03:03:57PM -0600, Larry Finger wrote: > Michael Buesch wrote: > > On Saturday 03 March 2007 20:03, Sam Ravnborg wrote: > >> Replacing use of UTS_RELEASE with utsname()->release > >> avoids that this module is rebuild each > >> time the kernel version changes. > >> > >> Compile tested only. > > > > I vote to get rid of the whole bcm43xx_ethtool.c file, as it's useless. > > It will vanish with the advent of d80211, anyway. > > Larry? > > Is bcm43xx_ethtool.c really useless? If so, I vote to remove it. I have never tried to use ethtool > on bcm43xx. Similarly, it isn't very often that I recompile the kernel when bcm43xx hasn't changed > and would not have noticed the bug that Sam reported. I saw it only because I tossed around with a allmodconfig build. I do not care if it is fixed one way or the other - but I like that only relevant parts are rebuild when kernel version changes. Sam - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html