Search Linux Wireless

Re: [PATCH 8/28] rt2x00: optimize mac/bssid writing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > Do you writel this array in a loop inside of register_multiwrite?
> > > If yes, it's broken. writel expects values in CPU endianess.
> > > This array will always be little endian.
> > 
> > register_multiread uses memcpy_fromio(), and
> > register_multiwrite uses memcpy_toio().
> 
> Ah, ok.
> 
> > So that should be safe to use right?
> 
> Yes.
> 
> > Otherwise would making register_multiwrite  accept a void* pointer be better?
> 
> Yeah it would. The argument type is wrong. If the function uses
> memcpy_foo it expects an u8 array (or void array, whatever you prefer).

Ok, thanks. I'll fix this as soon as possible.

Ivo
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux