On Tuesday 27 February 2007 16:19, Helge Deller wrote: > Patch below > - uses PCI_DEVICE macro > - adds a "const" to the p54_ops struct and > - replaces "__attribute__ ((packed))" by the generic "__packed" keyword. > > Signed-off-by: Helge Deller <deller@xxxxxx> > > PS: There are more possibilities to replace "__attribute__ ((packed))" by > the "__packed". Is this wished ? If yes, I can send additional patches for > the other subdirectories... > If you don't mind, please split each cleanup into a separate patch and do all d80211 drivers at the same time. adm8211 can also use the PCI_DEVICE cleanup, and adm8211, rt2x00, rtl8187, and zd1211rw can also switch to a const ieee80211_ops struct. I don't take patches for rt2x00 so you can either have a patch with the adm8211/p54/zd1211rw ieee80211_ops cleanup and another with the rt2x00 ieee80211_ops cleanup or you can make one big ieee80211_ops patch and let Linville apply that patch. As for the __packed cleanup, I do not see any code in the kernel that uses __packed, so I think it would be better if we dropped that for now. Thanks, -Michael Wu
Attachment:
pgpUkc9Ts5rsb.pgp
Description: PGP signature
