On Wednesday 21 February 2007 17:02, Ivo van Doorn wrote:
> Currently d80211 only uses a single variable for antenna selection,
> some devices (rt2x00) can configure the TX and RX antenna
> seperately from eachother.
> Assuming that antenna_sel is only for tx, and rx is "the other antenna"
> is flawed and does hinder possible switching of RX antenna based
> on RSSI results. And configuring the wrong antenna also impacts
> transfer rates and link quality.
>
> This patch will remove the usage of the IOCTL call:
> PRISM2_PARAM_ANTENNA_SEL but will restore the usage of
> (the already excisting) IOCTL calls PRISM2_PARAM_ANTSEL_TX and
> PRISM2_PARAM_ANTSEL_RX.
>
> Signed-off-by: Ivo van Doorn <IvDoorn@xxxxxxxxx>
>
> ---
>
> diff --git a/include/net/d80211.h b/include/net/d80211.h
> index 551fe46..68c8c8a 100644
> --- a/include/net/d80211.h
> +++ b/include/net/d80211.h
> @@ -196,7 +196,8 @@ struct ieee80211_tx_control {
> * above */
> u8 retry_limit; /* 1 = only first attempt, 2 = one retry, .. */
> u8 power_level; /* per-packet transmit power level, in dBm */
> - u8 antenna_sel; /* 0 = default/diversity, 1 = Ant0, 2 = Ant1 */
> + u8 antenna_sel_tx; /* 0 = default/diversity, 1 = Ant0, 2 = Ant1 */
> + u8 antenna_sel_rx; /* 0 = default/diversity, 1 = Ant0, 2 = Ant1 */
This doesn't make sense to me.
Why should we want to set the RX antenna on TXing a packet?
> s8 key_idx; /* -1 = do not encrypt, >= 0 keyidx from
> * hw->set_key() */
> u8 icv_len; /* length of the ICV/MIC field in octets */
> @@ -285,10 +286,9 @@ struct ieee80211_conf {
> u8 antenna_max; /* maximum antenna gain */
> short tx_power_reduction; /* in 0.1 dBm */
>
> - int antenna_sel; /* default antenna conf:
> - * 0 = default/diversity,
> - * 1 = Ant0,
> - * 2 = Ant1 */
> + /* 0 = default/diversity, 1 = Ant0, 2 = Ant1 */
> + u8 antenna_sel_tx;
> + u8 antenna_sel_rx;
This makes sense, yes. I ack this.
--
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
