On Fri, 16 Feb 2007 23:12:06 +0100, Johannes Berg wrote: > On Fri, 2007-02-16 at 23:07 +0100, Ivo van Doorn wrote: > > On Friday 16 February 2007 22:14, Johannes Berg wrote: > > > Make the counter per-mac address? > > > > Wouldn't that be the same as per-interface? > > Don't WDS interfaces have the same MAC as the corresponding AP > interface? They do. Per-MAC address counters would work but it's another overhead we need to add (allocate a new reference-counted structure, put a pointer to it into sdata, correctly deal with it when MAC address changes). I think we can live with the counter in sdata. It's not perfect but it should work for all useful cases. The only situation where it won't work I have been able to imagine is the case I described (STA and WDS with the same address) and this particular setup is currently being denied by d80211 (and it's not allowed by 802.11, btw). If we consider this as a problem later, we can always change to per-MAC address counters or something as it's completely internal to the stack and no driver changes would be required. Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
