i2400m_power_save_disabled Module parameter i2400m_power_save_disabled was defined twice. It is being= =20 removed by this patch. Signed-off-by: Oleg Yakovenko <oyakovenko at yotateam.ru> --- drivers/net/wimax/i2400m/driver.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/net/wimax/i2400m/driver.c b/drivers/net/wimax/i2400m/d= river.c index 1dbef36..5beb3ef 100644 --- a/drivers/net/wimax/i2400m/driver.c +++ b/drivers/net/wimax/i2400m/driver.c @@ -98,14 +98,6 @@ MODULE_PARM_DESC(power_save_disabled, "False by default (so the device is told to do power " "saving)."); =20 -int i2400m_power_save_disabled; /* 0 (power saving enabled) by default */ -module_param_named(power_save_disabled, i2400m_power_save_disabled, int, 0= 644); -MODULE_PARM_DESC(power_save_disabled, - "If true, the driver will not tell the device to enter " - "power saving mode when it reports it is ready for it. " - "False by default (so the device is told to do power " - "saving)."); - /** * i2400m_queue_work - schedule work on a i2400m's queue * --=20 1.6.0.4 > If you inline manually, watchout for tab-to-space conversion and line > wrap around. >=20 > I've inlined for commenting >=20 > > From dc82a3bd18d197774083c640342a825d4e910cfd Mon Sep 17 00:00:00 > 2001 > > From: Oleg Yakovenko <oyakovenko at yotateam.ru> > > Date: Wed, 9 Sep 2009 20:15:37 +0400 > > Subject: [PATCH] Remove a double definition of > i2400m_power_save_disabled >=20 > Missing subsystem header. Add a "wimax/i2400m:" header, so in the > kernel > commit logs, the single line description can tell what the patch > applies > to (wimax subsystem, i2400m driver). Obviosuly for other driver, it'd > be > something like 'scsi/aha912x:'. >=20 > Missing longer description: even if this is a one liner, explain why > the > commit: >=20 > "Module paraemter i2400m_power_save_disabled was defined twice; seems > it > wasn't caught by the empty headed maintainer...yadah yadah...". >=20 > Missing "Signed-off-by": this tracks authorship of patches and the fact > that you own the code: >=20 > Signed-off-by: Your Name <your.name at email> >=20 > Use the pointers in the Linux kernel Documentation/ Submit* documents, > they are quite useful. Also the check-patch script in scripts/ helps a > lot. > > Is my understanding correct that Inaky maintains the whole wimax > > source (both drivers and the stack) and sometimes it gets merged to > > the mainline kernel? >=20 > Yes. whenever the merge window open, I submit feature enhancements and > minor bug fixes. Major bug fixes I send as they pop up. What about the different branches? I see there are these branches in your repository: -- master =09 -- op_nap_scan=20 -- linux-2.6.31.y -- linux-2.6.30.y -- linux-2.6.29.y Is it correct to say that linux-2.6* branches are used for creating patches against a corresponding linux- version, the master branch is used for main development and the op_nap_scan branch will be merged to master branch when the work is done there? Thanks, O.
