On Wednesday 07 January 2009, Ilpo J?rvinen wrote: > On Tue, 6 Jan 2009, Inaky Perez-Gonzalez wrote: > > Reported by Randy Dunlap: > > > Also, this warning needs to be fixed: > > > > > > linux-next-20090106/net/wimax/id-table.c:133: warning: ISO C90 > > > forbids mixed declarations and code > > > > Move the return on #defined(CONFIG_BUG) below the variable > > declarations so it doesn't violate ISO C90. > > > > On wimax_id_table_release() we want to do a debug check if CONFIG_BUG > > is enabled. However, we also want the debug code to be always compiled > > to ensure there is no bitrot. > > I hope this kind of solution won't add some warnings? Besides, this seems > rather strange reasoning as CONFIG_BUG is mostly enabled anyway? Well, it is legal code -- short of 'if (1) return'. It doesn't warn (and it should not). > > -#ifndef CONFIG_BUG > > - return; > > -#endif > > struct wimax_dev *wimax_dev; > > > > +#ifdef CONFIG_BUG > > Did you perhaps mean ifndef here??? :-) Sigh ... you are right ... good thing I triple checked. Sending updated patch series. Thanks, -- Inaky
