On Sun, Jan 26, 2025 at 11:09:01PM -0600, Rob Herring wrote: > On Sun, Jan 26, 2025 at 07:59:03PM +0100, J. Neuschäfer wrote: > > fsl-spi.txt contains the bindings for the fsl,spi and fsl,espi > > contollers. Convert them to YAML. > > > > Signed-off-by: J. Neuschäfer <j.ne@xxxxxxxxxx> > > --- > > .../devicetree/bindings/spi/fsl,espi.yaml | 56 +++++++++++++++++ > > Documentation/devicetree/bindings/spi/fsl,spi.yaml | 71 ++++++++++++++++++++++ > > Documentation/devicetree/bindings/spi/fsl-spi.txt | 62 ------------------- > > 3 files changed, 127 insertions(+), 62 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/spi/fsl,espi.yaml b/Documentation/devicetree/bindings/spi/fsl,espi.yaml > > new file mode 100644 > > index 0000000000000000000000000000000000000000..350275760210c5763af0c7b1e1522ccbfb97eec7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/fsl,espi.yaml > > @@ -0,0 +1,56 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/spi/fsl,espi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale eSPI (Enhanced Serial Peripheral Interface) controller > > + > > +maintainers: > > + - J. Neuschäfer <j.ne@xxxxxxxxxx> > > + > > +properties: > > + compatible: > > + const: fsl,mpc8536-espi > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: true > > How many? > > > + > > + fsl,espi-num-chipselects: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: The number of the chipselect signals. > > Constraints? > > > + > > + fsl,csbef: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: Chip select assertion time in bits before frame starts > > Constraints? > > > + > > + fsl,csaft: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: Chip select negation time in bits after frame ends > > Constraints? I'll add appropriate constraints to all of these. > > diff --git a/Documentation/devicetree/bindings/spi/fsl,spi.yaml b/Documentation/devicetree/bindings/spi/fsl,spi.yaml [...] > > + clock-frequency: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > Don't need a type. Will remove > > > + description: input clock frequency to non FSL_SOC cores > > + > > + cs-gpios: true > > + > > + fsl,spisel_boot: > > + $ref: /schemas/types.yaml#/definitions/flag I do wonder, what's the difference between $ref: /schemas/types.yaml#/definitions/flag and type: boolean? Thanks for your review. Best regards, J. Neuschäfer
