RE: [PATCH 3/5] watchdog: Make RZV2HWDT driver depend on ARCH_R9A09G47

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof Kozlowski,

Thanks for the feedback.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 18 January 2025 15:51
> Subject: Re: [PATCH 3/5] watchdog: Make RZV2HWDT driver depend on ARCH_R9A09G47
> 
> On Wed, Jan 15, 2025 at 10:38:52AM +0000, Biju Das wrote:
> > RZ/G3E watchdog timer IP is similar to the one found on RZ/V2H.
> > Add Kconfig dependency for RZV2HWDT driver with ARCH_R9A09G47 and
> > update the help description.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> >  drivers/watchdog/Kconfig | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index
> > f81705f8539a..646a84cc03e3 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -963,13 +963,14 @@ config RENESAS_RZG2LWDT
> >  	  Renesas RZ/G2L SoCs. These watchdogs can be used to reset a system.
> >
> >  config RENESAS_RZV2HWDT
> > -	tristate "Renesas RZ/V2H(P) WDT Watchdog"
> > -	depends on ARCH_R9A09G057 || COMPILE_TEST
> > +	tristate "Renesas RZ/{G3E,V2H(P)} WDT Watchdog"
> 
> This is close to churn...
> 
> > +	depends on ARCH_R9A09G047 || ARCH_R9A09G057 || COMPILE_TEST
> 
> But this is just wrong. You are supposed to depend on renesas ARHC, not your individual SoC (and this
> is what you called here "ARCH_R9A...").
> 
> Greg many times gave strong opinion that even full ARCH is wrong and we managed to convince him that
> it has a meaning (or he did not want to keep discussing). But restricting it per soc is pointless and
> impossible to defend in discussion.

Currently for building RZ/G3E WDT, I need to always have RZ/V2H SoC config.
which is pointless. May be ARCH_RENESAS should ok in this case??

Cheers,
Biju




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux