On 10/15/24 04:37, Jean Delvare wrote:
This driver has a number of issues (accesses arbitrary I/O ports without identifying the hardware, doesn't document what hardware it supports, suspiciously inconsistent locking model, doesn't implement WDIOC_SETTIMEOUT, potential integer overflow...) The driver was added in 2003 and there's no evidence that it has any recent user, all changes seem to be tree-wide, subsystem-wide, or the result of static code analysis. So I believe we should simply drop this legacy piece of code. Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> Message-ID: <20241011170710.484a257a@endymion.delvare>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> Ultimately we should consider removing all watchdog drivers not implementing the watchdog API, or at least declare them deprecated. Guenter
