[PATCH v3] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: mika.westerberg@xxxxxxxxxxxxxxx
Subject: [PATCH v3] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call
From: Oleksandr Ocheretnyi <oocheret@xxxxxxxxx>
Date: Mon, 7 Oct 2024 08:57:02 -0700
Cc: linux@xxxxxxxxxxxx, jdelvare@xxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-watchdog@xxxxxxxxxxxxxxx, wim@xxxxxxxxxxxxxxxxxx, wsa@xxxxxxxxxx, xe-linux-external@xxxxxxxxx
In-reply-to: <05dba51b-7c3c-4455-9c97-09777e885fac@roeck-us.net>
References: <05dba51b-7c3c-4455-9c97-09777e885fac@roeck-us.net>

Hello Mika,

> I suggest adding some #define for the magical number 8 so that it is
> easier for anyone looking at this driver to figure out what it is doing.

Are the changes with #define NMI_NOW bit fine for you?

Best regards,
Oleksandr

Follow-Ups:
- Re: [PATCH v3] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call
  - From: Mika Westerberg

References:
- Re: [PATCH v3] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call
  - From: Guenter Roeck

Prev by Date: Re: [PATCH v3 4/4] watchdog: rzg2l_wdt: Power on the watchdog domain in the restart handler
Next by Date: Re: [PATCH 1/4] dt-bindings: watchdog: aspeed: Add property for WDT SW reset
Previous by thread: Re: [PATCH v3] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call
Next by thread: Re: [PATCH v3] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux