Re: [PATCH] watchdog: da9063: Do not use a global variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Fabio Estevam <festevam@xxxxxxxxx>
Subject: Re: [PATCH] watchdog: da9063: Do not use a global variable
From: Guenter Roeck <linux@xxxxxxxxxxxx>
Date: Mon, 2 Sep 2024 18:04:56 -0700
Cc: support.opensource@xxxxxxxxxxx, linux-watchdog@xxxxxxxxxxxxxxx, Fabio Estevam <festevam@xxxxxxx>
In-reply-to: <20240902224504.1012750-1-festevam@gmail.com>
References: <20240902224504.1012750-1-festevam@gmail.com>
User-agent: Mozilla Thunderbird

On 9/2/24 15:45, Fabio Estevam wrote:

From: Fabio Estevam <festevam@xxxxxxx>

Using the 'use_sw_pm' variable as global is not recommended
as it prevents multi instances of the driver to run.

Make it a member of the da9063 structure instead.

Signed-off-by: Fabio Estevam <festevam@xxxxxxx>


Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

References:
- [PATCH] watchdog: da9063: Do not use a global variable
  - From: Fabio Estevam

Prev by Date: [PATCH] watchdog: da9063: Do not use a global variable
Next by Date: [PATCH v2] watchdog: iTCO_wdt: Convert comma to semicolon
Previous by thread: [PATCH] watchdog: da9063: Do not use a global variable
Next by thread: Re: [PATCH] watchdog: da9063: Do not use a global variable
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux