On 2024/8/31 4:09, Guenter Roeck wrote:
On Fri, Aug 30, 2024 at 04:02:20PM +0800, Hongbo Li wrote:
The function simple_strtoul performs no error checking
in scenarios where the input value overflows the intended
output variable.
We can replace the use of the simple_strtoul with the safer
alternatives kstrtoul. For fail case, we also print the extra
message.
I really don't see value in this patch, sorry. If the driver is still
in use somewhere, it would be much more valuable to convert it to use
the watchdog subsystem API, which would also address the above.
In general people should refrain from "improving" old watchdog drivers
unless they are also converted to use the watchdog subsystem API,
or unless a real bug is fixed.
Sorry, I haven't noticed this.
Thanks,
Hongbo
Guenter
