On 25/07/2024 17:03, Kousik Sanagavarapu wrote: > Convert txt bindings of TI's DaVinci/Keystone Watchdog Timer Controller > to dtschema to allow for validation. > > While at it, change the order of the compatibles w.r.t. the txt binding > to stay in sync with the existing DTS. ... and add power-domains property, because it is used somwhere? > > Signed-off-by: Kousik Sanagavarapu <five231003@xxxxxxxxx> > --- > .../bindings/watchdog/davinci-wdt.txt | 24 --------- > .../bindings/watchdog/ti,davinci-wdt.yaml | 52 +++++++++++++++++++ > 2 files changed, 52 insertions(+), 24 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/davinci-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt > deleted file mode 100644 > index aa10b8ec36e2..000000000000 > --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt > +++ /dev/null > @@ -1,24 +0,0 @@ > -Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller > - ... > + - Kousik Sanagavarapu <five231003@xxxxxxxxx> > + > +description: | > + TI's Watchdog Timer Controller for DaVinci and Keystone Processors. > + > + Datasheets > + > + Davinci DM646x - https://www.ti.com/lit/ug/spruer5b/spruer5b.pdf > + Keystone - https://www.ti.com/lit/ug/sprugv5a/sprugv5a.pdf > + > +allOf: > + - $ref: watchdog.yaml# > + > +properties: > + compatible: > + items: > + - const: ti,keystone-wdt > + - const: ti,davinci-wdt Validate the DTS - you will see this is wrong. You miss davinci standing alone (so oneOf). Best regards, Krzysztof
