On 22/07/2024 15:12, Kousik Sanagavarapu wrote: > On Mon, Jul 22, 2024 at 10:15:03AM +0200, Krzysztof Kozlowski wrote: >> On 21/07/2024 18:28, Kousik Sanagavarapu wrote: >>> +properties: >>> + compatible: >>> + enum: >>> + - ti,davinci-wdt >>> + - ti,keystone-wdt >> >> This does not match the original binding and commit msg did not explain >> why such change is necessary. > > I don't understand. Do you mean both the compatibles are always > compulsory? Meaning > > compatible: > items: > - const: ti,davinci-wdt > - const: ti,keystone-wdt Yes, this is what old binding said. > > It is enum because I intended it to align with the subsequent patch > which changes DTS. > >> This also does not match DTS. > > Yes. I've asked about changing the DTS in the subsequent patch. > Changing the DTS cannot be the reason to affect users and DTS... It's tautology. You change DTS because you intent to change DTS? Best regards, Krzysztof