On Mon, Jun 17, 2024 at 05:26:03PM +0200, Marek Behún wrote: > Add support for the watchdog mechanism provided by the MCU. > > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx> > Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> > --- [ ... ] > +static unsigned int omnia_wdt_get_timeleft(struct watchdog_device *wdt) > +{ > + struct omnia_mcu *mcu = watchdog_get_drvdata(wdt); > + u16 timeleft; > + int err; > + > + err = omnia_cmd_read_u16(mcu->client, OMNIA_CMD_GET_WDT_TIMELEFT, > + &timeleft); > + if (err) { > + dev_err(&mcu->client->dev, "Cannot get watchdog timeleft: %d\n", > + err); If that ever happens, it is likely going to be persistent, and will clog the kernel log. But then I figure it is not really worth arguing about, so Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> Guenter