Re: [PATCH v11 5/8] platform: cznic: turris-omnia-mcu: Add support for MCU watchdog

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Jun 5, 2024 at 7:19 PM Marek Behún <kabel@xxxxxxxxxx> wrote:
>
> Add support for the watchdog mechanism provided by the MCU.

...

+ bitops.h
+ dev_printk.h

> +#include <linux/i2c.h>
> +#include <linux/moduleparam.h>

> +#include <linux/turris-omnia-mcu-interface.h>

As per other patches.

> +#include <linux/types.h>
> +#include <linux/units.h>
> +#include <linux/watchdog.h>
> +
> +#include "turris-omnia-mcu.h"

struct device;

Alternatively instead of dev_printk.h + struct device forward
declaration --> device.h.

...

With the above being addressed, LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko