On Wed, 2024-04-03 at 12:13 -0500, Rob Herring wrote: > On Wed, Apr 03, 2024 at 12:34:39PM +1030, Andrew Jeffery wrote: > > Squash warnings such as: > > > > ``` > > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-galaxy100.dtb: /ahb/apb@1e600000/watchdog@1e785000: failed to match any schema with compatible: ['aspeed,ast2400-wdt'] > > ``` > > > > The schema binding additionally defines the clocks property over the > > prose binding to align with use of the node in the DTS files. > > > > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx> > > --- > > v2: Address feedback from Rob and Zev > > > > - Rob: https://lore.kernel.org/linux-watchdog/20240402180718.GA358505-robh@xxxxxxxxxx/ > > - Zev: https://lore.kernel.org/linux-watchdog/65722a59-2e94-4616-81e1-835615b0e600@xxxxxxxxxxxxxxxxxxxxxxxx/ > > > > v1: https://lore.kernel.org/linux-watchdog/20240402120118.282035-1-andrew@xxxxxxxxxxxxxxxxxxxx/ > > > > .../bindings/watchdog/aspeed,ast2400-wdt.yaml | 142 ++++++++++++++++++ > > .../bindings/watchdog/aspeed-wdt.txt | 73 --------- > > 2 files changed, 142 insertions(+), 73 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml > > delete mode 100644 Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > > > > diff --git a/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml b/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml > > new file mode 100644 > > index 000000000000..be78a9865584 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml > > @@ -0,0 +1,142 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/watchdog/aspeed,ast2400-wdt.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Aspeed watchdog timer controllers > > + > > +maintainers: > > + - Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-wdt > > + - aspeed,ast2500-wdt > > + - aspeed,ast2600-wdt > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + description: > > > You don't need '>' either. I guess it is equivalent here as there are no > double newlines. Drop these if you respin, otherwise: > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Thanks. I've made a note for the future to avoid `>` if it's not necessary, but at the time I figured it wasn't incorrect to include it. Andrew
