On Sun, 24 Mar 2024 17:30:39 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Sun, Mar 24, 2024 at 5:04 PM Marek Behún <kabel@xxxxxxxxxx> wrote: > > > > Hi Andy, > > > > thank you very much for the review. I have some notes and some > > questions, see below. > > Btw, I'll look into other patches next week. Thx. ... > > > > There are still some people wanting only 80 columns, and the whole > > driver is written that way. > > Hmm... Is it still a hard limit for drivers/platform/cznic for the _new_ code? I don't think so, but I personally would also prefer leaving this at 80 columns. Is this a problem? > > I considered it a helper function that should be defined in the header > > file, like the rest of the cmd helpers in this file. If you disagree, I > > will put it into the -base.c file. > > I don't see the technical justification to hold it in the *.h rather > than *.c. To me this one is big enough in C and likely in assembly to > be copied to each user. Besides that aspect, it slows down the build a > lot (mostly due to i2c.h inclusion which otherwise is not needed). OK, I moved it into -base.c. Marek
