On Fri, Jan 19, 2024 at 1:50 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On 1/19/24 00:43, Lukasz Majczak wrote: > > Chromeos devices are equipped with the embedded controller (EC) > > that can be used as a watchdog. The following patches > > updates the structures and definitions required to > > communicate with EC-based watchdog and implements the > > driver itself. > > > > The previous version of this patch was sent here: > > https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925 > > > > Changelog > > V2->V3: > > * drop "-drv" from driver name > > * use format #define<space>NAME<tab>value > > > > I am a bit lost here. You dropped my Reviewed-by: tags, even though > I specifically said that they applied with those changes made. > Also, according to the above patch 1/3 was not changed at all. > > What else did you change that warrants dropping the tags ? > > Guenter > The "-drv" change was related to patch 2 and 3, and I have used "format #define<space>NAME<tab>value" only in patch 3 (as ec_commands.h is mixing those) Sorry for dropping your "Reviewed-by" tag :( I've assumed (wrong) that I cannot take it for granted sending V3. Alos in such a case if there are changes in patch 2 and 3 and 1 remains untouched shall I send only 2 and 3 in the next version ? Best regards, Lukasz
