On Thu, Jan 18, 2024 at 07:53:23PM +0000, Lukasz Majczak wrote: > Embedded Controller (EC) present on Chromebook devices > can be used as a watchdog. > Implement a driver to support it. > > Signed-off-by: Lukasz Majczak <lma@xxxxxxxxxxxx> Nits: > +#define CROS_EC_WATCHDOG_DEFAULT_TIME 30 /* seconds */ > +#define DRV_NAME "cros-ec-wdt-drv" #define<space>NAME<tab>value please, and "-drv" in the driver name is really unnecessary. With that changed, Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> Thanks, Guenter