On 17/01/2024 11:24, Lukasz Majczak wrote: Few more nits: > This adds EC-based watchdog support for ChromeOS Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > based devices equipped with embedded controller (EC). > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. And not a nit - important: Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools are doing it automatically, so either you work on some ancient tree (don't), on fork of kernel (don't) or ignore some maintainers (really don't). Best regards, Krzysztof
