On 14/12/2023 16:04, Elad Nachman wrote:
> From: Elad Nachman <enachman@xxxxxxxxxxx>
>
> Add watchdog nodes to ac5 and ac5x device tree files
>
> Signed-off-by: Elad Nachman <enachman@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi | 14 ++++++++++++++
> arch/arm64/boot/dts/marvell/ac5-98dx35xx.dtsi | 8 ++++++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> index b5e042b8e929..e898c6bd31f0 100644
> --- a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> @@ -307,6 +307,20 @@ nand: nand-controller@805b0000 {
> status = "disabled";
> };
>
> +/*
> + * Global Watchdog:
> + */
Messed indentation. Also unnecessary line breaks around comment, unless
you have some KPI per lines of code. If it is the only watchdog, why
even commenting on it?
> + watchdog: watchdog@80216000 {
> + compatible = "marvell,ac5-wd";
> + reg = <0x0 0x80216000 0 0x1000>,
> + <0x0 0x80215000 0 0x1000>,
> + <0x0 0x80210000 0 0x1000>,
> + <0x0 0x7f900000 0 0x1000>,
> + <0x0 0x840F8000 0 0x1000>;
Lowercase hex.
Best regards,
Krzysztof
