On 11/12/2023 20:46, Peter Griffin wrote: >>> +#include <linux/platform_device.h> > > You are correct, this header isn't required. If a new series is > required I will remove it. I dropped it while applying. > > Whilst you're here I'd like to draw your attention to [PATCH 2/16] > where I've removed your reviewed-by tag in v7 because I added the ect > node documentation in google.yaml. The empty ect node is required to > be present by the bootloader or the device will boot loop. Can you > re-review that patch? > > The alternative is to remove the empty ect node, and the binding > documentation for it and add your Reviewed-by tag back again. But then > an upstream kernel won't boot 'out the box' on a pixel 6 which seems > less than ideal default behaviour. Best regards, Krzysztof
