Re: [PATCH v3.1 3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

On Mon, Dec 4, 2023 at 6:25 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Document DA9063 watchdog device as it is similar to DA9062 watchdog.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> ---
> v3->v3.1:
>  * Added Ack from Conor Dooley.
>  * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063.
>  * Retained Rb tag since the changes are trivial.

Thanks for the update!

> --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml

> @@ -18,6 +18,7 @@ properties:
>        - items:
>            - enum:
>                - dlg,da9062-watchdog
> +              - dlg,da9063-watchdog
>        - items:
>            - const: dlg,da9061-watchdog
>            - const: dlg,da9062-watchdog

This matches the existing usage in DT, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

However, I believe we do have a runtime issue here, as the driver
currently matches against dlg,da9062-watchdog only, so the watchdog
must be non-functional on DA9063?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux