On Mon, Dec 04, 2023 at 10:55:20AM +0000, Biju Das wrote: > Hi Conor Dooley, > > > Subject: RE: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: > > Add fallback for DA9061 watchdog > > > > Hi Conor Dooley, > > > > Thanks for the feedback. > > > > > Subject: Re: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062- > > watchdog: > > > Add fallback for DA9061 watchdog > > > > > > On Sat, Dec 02, 2023 at 07:25:25PM +0000, Biju Das wrote: > > > > The DA9061 watchdog is identical to DA9062 watchdog, so no driver > > > > changes are required. The fallback compatible string > > > > "dlg,da9062-watchdog" will be used on DA9061 watchdog. > > > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > > --- > > > > v2: > > > > * New patch > > > > --- > > > > .../bindings/watchdog/dlg,da9062-watchdog.yaml | 11 ++++++++-- > > - > > > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam > > > > l > > > > b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam > > > > l index f058628bb632..2b71fdb9251c 100644 > > > > --- > > > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam > > > > l > > > > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog > > > > +++ .y > > > > +++ aml > > > > @@ -14,9 +14,14 @@ allOf: > > > > > > > > properties: > > > > compatible: > > > > - enum: > > > > - - dlg,da9061-watchdog > > > > - - dlg,da9062-watchdog > > > > + oneOf: > > > > + - items: > > > > + - enum: > > > > + - dlg,da9062-watchdog > > > > + - items: > > > > + - enum: > > > > + - dlg,da9061-watchdog > > > > > > If there is no da9064 on the horizon, I'd just make this const. > > > > You mean since it is single device having a fallback, define both device > > compatible and fallback as const instead of enum and const?? > > > > > > > > > + - const: dlg,da9062-watchdog # da9062-watchdog fallback > > > > > > The comment here is just noise IMO. > > Yes it make sense, comment is not needed. > > oneOf: > - items: > - enum: > - dlg,da9062-watchdog > - items: > - const: dlg,da9061-watchdog > - const: dlg,da9062-watchdog Ye, this looks good. Thanks.
Attachment:
signature.asc
Description: PGP signature
