Hi Sam, Thanks for the review. On Fri, 1 Dec 2023 at 20:22, Sam Protsenko <semen.protsenko@xxxxxxxxxx> wrote: > > On Fri, Dec 1, 2023 at 10:10 AM Peter Griffin <peter.griffin@xxxxxxxxxx> wrote: > > > > This introduces bindings and dt-schema for the Google tensor SoCs. > > Currently just gs101 and pixel 6 are supported. > > > > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > Other than spelling comments below: > > git st > > > .../devicetree/bindings/arm/google.yaml | 53 +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/google.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/google.yaml b/Documentation/devicetree/bindings/arm/google.yaml > > new file mode 100644 > > index 000000000000..be191e70192d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/google.yaml > > @@ -0,0 +1,53 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/google.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Google Tensor platforms > > + > > +maintainers: > > + - Peter Griffin <peter.griffin@xxxxxxxxxx> > > + > > +description: | > > + ARM platforms using SoCs designed by Google branded "Tensor" used in Pixel > > + devices. > > + > > + Currently upstream this is devices using "gs101" SoC which is found in Pixel > > + 6, Pixel 6 Pro and Pixel 6a. > > + > > + Google have a few different names for the SoC. > > Suggest removing period, or replacing it with colon. will fix > > > + - Marketing name ("Tensor") > > + - Codename ("Whitechapel") > > + - SoC ID ("gs101") > > + - Die ID ("S5P9845"); > > Semicolon seems off here. will fix > > > + > > + Likewise there are a couple of names for the actual device > > + - Marketing name ("Pixel 6") > > + - Codename ("Oriole") > > + > > + Devicetrees should use the lowercased SoC ID and lowercased board codename. > > period -> comma > > > + e.g. gs101 and gs101-oriole > > Missing period character. will fix Peter > > > + > > +properties: > > + $nodename: > > + const: '/' > > + compatible: > > + oneOf: > > + - description: Google Pixel 6 / Oriole > > + items: > > + - enum: > > + - google,gs101-oriole > > + - const: google,gs101 > > + > > + # Bootloader requires empty ect node to be present > > + ect: > > + type: object > > + additionalProperties: false > > + > > +required: > > + - ect > > + > > +additionalProperties: true > > + > > +... > > -- > > 2.43.0.rc2.451.g8631bc7472-goog > >
