On 10/11/2023 09:09, Krzysztof Kozlowski wrote: > On 10/11/2023 01:30, Daniel Golle wrote: >> Add binding description for mediatek,mt7988-wdt. >> >> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx> >> --- > > ... > >> diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h >> new file mode 100644 >> index 0000000000000..fa7c937505e08 >> --- /dev/null >> +++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h >> @@ -0,0 +1,12 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >> + >> +/* TOPRGU resets */ >> +#define MT7988_TOPRGU_SGMII0_GRST 1 >> +#define MT7988_TOPRGU_SGMII1_GRST 2 >> +#define MT7988_TOPRGU_XFI0_GRST 12 >> +#define MT7988_TOPRGU_XFI1_GRST 13 >> +#define MT7988_TOPRGU_XFI_PEXTP0_GRST 14 >> +#define MT7988_TOPRGU_XFI_PEXTP1_GRST 15 >> +#define MT7988_TOPRGU_XFI_PLL_GRST 16 > > IDs should start from 0 or 1 and increment by 1. If these are not IDs, > then you do not need them in the bindings. > > Where is the driver change using these IDs? You nicely skipped my email and keep pushing the idea of putting this into separate patch. No. Respond to received comments. > >> + >> +#define MT7988_TOPRGU_SW_RST_NUM 24 > > Why 24? I see 7. Why having it in the bindings in the first place. > > It's quite likely I asked the same question about other bindings for > Mediatek. I will be asking every time till this is fixed. No response to this, either. Best regards, Krzysztof
