Re: [v2 PATCH] dt-bindings: watchdog: da9062-wdt: convert txt to yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>This property is a boolean...
>
>> +    description:
>> +      Set what happens on watchdog timeout. If this bit is set the
>> +      watchdog timeout triggers SHUTDOWN, if cleared the watchdog triggers
>> +      POWERDOWN. Can be 0 or 1.
>
>... but you say "can be 0 or 1". Does this refer to the bit value, or
>the property? There are no in-kernel users of this property as far as a
>quick grep shows so it is a bi hard to tell.
>
>Otherwise, I'm happy with this.
>
>Thanks,
>Conor.

Hello, thank you for your review!

Good point. 
It looks like it is related to property itself. 

I checked other bindings, like https://www.kernel.org/doc/Documentation/devicetree/bindings/iio/adc/adi%2Cad7192.yaml . They have fields of type boolean with description “When this bit is set to 1”.
So I put it as boolean.

I have just checked a couple more, and looks like they are mostly uint32 types with enum, when it goes about 0, 1 bit value in a description.  
$ref: /schemas/types.yaml#/definitions/uint32
enum: [0, 1]

I will update. 

Thank you. 



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux