Hi Krzysztof, On 10/12/2023, Krzysztof Kozlowski wrote: > On 12/10/2023 12:45, Peter Griffin wrote: > > Hi Krzysztof, > > > > On Thu, 12 Oct 2023 at 10:36, Krzysztof Kozlowski > > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> > >> On 12/10/2023 10:56, Peter Griffin wrote: > >>> Hi Krzysztof, > >>> > >>> On Thu, 12 Oct 2023 at 07:07, Krzysztof Kozlowski > >>> <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >>>> > >>>> On 11/10/2023 23:48, William McVicker wrote: > >>>>> On 10/11/2023, Peter Griffin wrote: > >>>>>> Provide dt-schema documentation for Google gs101 SoC clock controller. > >>>>>> Currently this adds support for cmu_top, cmu_misc and cmu_apm. > >>>>>> > >>>>>> Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> > >>>>> > >>>>> Tested-by: Will McVicker <willmcvicker@xxxxxxxxxx> > >>>> > >>>> And how do you perform testing of a binding? > >>> > >>> I guess if William is using my script to build and flash the kernel it actually > >>> runs the DTC checks as part of the build process. > >>> > >>> See https://git.codelinaro.org/linaro/googlelt/pixelscripts/-/blob/clo/main/buildp21upstream.sh#L44 > >> > >> So it is a build test? We do not consider building as a test procedure, > >> otherwise I should add my and robots tested-by to many other patches. > > > > Ok so I should only add the Tested-by on the .c patches? > > In my opinion, if someone performs only build testing, it is not a > testing. You cannot test the bindings other way than build testing, at > least I do not know such way. Of course other code like C or DTS affects > hardware so it can be tested. What additional testing beside building and booting do you prefer at this stage? I put my Tested-by for this patch because it includes the google,gs101.h header which is used by the DT and clock controller driver during boot. Maybe I should have been more clear on what I tested in each patch instead of only mentioning how I tested in the cover letter? Sorry for the confusion. Thanks, Will > > > > >> Shall I consider other Tested-by tags here also as build-tested only? > > > > No. William indicated here > > https://lore.kernel.org/linux-arm-kernel/ZScZu-QB2LmB4CSM@xxxxxxxxxx/T/#mbd96a26b725d6c85eb4193de8cd70ff277bc728e > > that he booted it on his Oriole device. > > > OK, I was just a bit confused. > > Best regards, > Krzysztof >
