On 12/10/2023 16:03, Peter Griffin wrote:
> Hi Krzysztof,
>
> On Thu, 12 Oct 2023 at 07:26, Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> On 11/10/2023 20:48, Peter Griffin wrote:
>>> Add serial driver data for Google Tensor gs101 SoC.
>>>
>>> Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
>>> ---
>>> drivers/tty/serial/samsung_tty.c | 13 +++++++++++++
>>> 1 file changed, 13 insertions(+)
>>>
>>> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
>>> index 07fb8a9dac63..26bc52e681a4 100644
>>> --- a/drivers/tty/serial/samsung_tty.c
>>> +++ b/drivers/tty/serial/samsung_tty.c
>>> @@ -2597,14 +2597,22 @@ static const struct s3c24xx_serial_drv_data exynos850_serial_drv_data = {
>>> .fifosize = { 256, 64, 64, 64 },
>>> };
>>>
>>> +static const struct s3c24xx_serial_drv_data gs101_serial_drv_data = {
>>> + EXYNOS_COMMON_SERIAL_DRV_DATA(),
>>> + /* rely on samsung,uart-fifosize DT property for fifosize */
>>
>> It's an optional property, so you cannot rely on it.
>
> Is it possible to make it a mandatory DT property for certain SoCs?
Yes.
>
>>
>>> + .fifosize = { 0 },
>
> I can update this to 256, and we can add more sizes as we enable other
> UARTs I suppose.
You might also want to fix Arnd's comment, but anyway drivers must be in
match with bindings.
>
> What's the purpose of having fifosize specified in DT and in *_serial_drv_data?
I guess safe defaults?
Best regards,
Krzysztof
