Hi On 2023/8/14 15:38, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > The simatic-ipc driver no longer depends on PCI, but its watchdog portion > still needs it, otherwise P2SB runs into a build failure: If the simatic-ipc driver no longer depends on PCI, you can delete the dependency here: https://elixir.bootlin.com/linux/v6.5-rc6/source/drivers/platform/x86/Kconfig#L1079 > > WARNING: unmet direct dependencies detected for P2SB > Depends on [n]: PCI [=n] && X86 [=y] > Selected by [m]: > - SIEMENS_SIMATIC_IPC_WDT [=m] && WATCHDOG [=y] && SIEMENS_SIMATIC_IPC [=y] > > drivers/platform/x86/p2sb.c:121:3: error: call to undeclared function 'pci_bus_write_config_dword'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > pci_bus_write_config_dword(bus, devfn_p2sb, P2SBC, 0); > > Add back the minimum dependendency to make it build in random configurations > again. > > Fixes: b72da71ce24b0 ("platform/x86: simatic-ipc: drop PCI runtime depends and header") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 04e9b40cf7d53..09452384221a4 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -1680,7 +1680,7 @@ config NIC7018_WDT > > config SIEMENS_SIMATIC_IPC_WDT > tristate "Siemens Simatic IPC Watchdog" > - depends on SIEMENS_SIMATIC_IPC > + depends on SIEMENS_SIMATIC_IPC && PCI The SIEMENS_SIMATIC_IPC_WDT does not depends on PCI directly, it should depends on P2SB, then P2SB depends on PCI > default y > select WATCHDOG_CORE > select P2SB You can replace the "select" to "depends on" instead. Reviewed-by: Xing Tong Wu <xingtong.wu@xxxxxxxxxxx> -- Xing Tong
