Am Tue, 18 Jul 2023 17:23:30 +0300 schrieb Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>: > On Tue, Jul 18, 2023 at 12:52:13PM +0200, Henning Schild wrote: > > Users without a Siemens Simatic IPC will not care about any of these > > drivers. Users who do care can enable the submenu and all drivers > > behind it will be enabled. > > ... > > > # Siemens Simatic Industrial PCs > > +obj-$(CONFIG_X86_PLATFORM_DRIVERS_SIEMENS) += > > siemens/ > > Do you need conditional here? We have stumbled over similar for > entire intel subfolder, it might affect the rest as well when you > don't expect it. > > obj-y += siemens/ > > ? > It was requested to be done like that by Hans, he wanted me to do a similar thing that https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f1e1ea516721d1ea0b21327ff9e6cb2c2bb86e28 is doing. And that is what i did. If there was a y ... the whole "one switch to rule them all" story would not work out anymore. Thanks for the review though. Henning
