On 14/04/2023 12:23, Bharat Bhushan wrote: > Add binding documentation for the Marvell octeonTX2 > GTI system watchdog driver. Subject: typo: atchdog > > Signed-off-by: Bharat Bhushan <bbhushan2@xxxxxxxxxxx> > --- > .../watchdog/marvell-octeontx2-wdt.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yaml b/Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yaml > new file mode 100644 > index 000000000000..e509f26c61b9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/marvell-octeontx2-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell OcteonTX2 GTI system watchdog > + > +allOf: > + - $ref: watchdog.yaml# > + > +maintainers: > + - Bharat Bhushan <bbhushan2@xxxxxxxxxxx> > + > +properties: > + compatible: > + const: marvell-octeontx2-wdt That's not correct compatible. marvell is a vendor prefix. Did you test the bindings before sending? > + > + reg: > + maxItems: 1 > + description: > + OcteonTX2 GTI system watchdog register space Drop description, it is obvious. > + > + interrupts: > + maxItems: 1 > + description: > + OcteonTX2 GTI system watchdog interrupt number Ditto > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false unevaluatedProperties: false instead > + > +examples: > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + watchdog@802000040000 { > + compatible = "marvell-octeontx2-wdt"; > + reg = <0x8020 0x40000 0x0 0x20000>; Are you sure that this is correct DTS? 32-bit numbers are usually 8-digit long. Plus size of 0x20000 is crazy huge. And the unit address is a bit unusual. Are you sure dtc W=1 does not say about any errors in your DTS? > + interrupts = <0 38 1>; Use defines for common flags. > + }; > + }; > + > +... Best regards, Krzysztof
