On 20/03/2023 10:44, Kathiravan T wrote:
> Add the nodes for QUP peripheral, PRNG and WDOG. While at it, enable the
> I2C device for MI01.2 board.
>
> Signed-off-by: Kathiravan T <quic_kathirav@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts | 14 +++++
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 67 +++++++++++++++++++++
> 2 files changed, 81 insertions(+)
Thank you for your patch. There is something to discuss/improve.
> +
> blsp1_uart0: serial@78af000 {
> compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
> reg = <0x078af000 0x200>;
> @@ -201,6 +218,48 @@
> status = "disabled";
> };
>
> + blsp1_spi0: spi@78b5000 {
> + compatible = "qcom,spi-qup-v2.2.1";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x078b5000 0x600>;
Please keep the reg as second property, after compatible.
Best regards,
Krzysztof
