On Mon, Mar 06, 2023 at 06:09:01PM +0100, Uwe Kleine-König wrote: > This allows to drop the .remove() function as it only exists to > unregister the watchdog device which is now done in a callback > registered by devm_watchdog_register_device(). > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > --- > drivers/watchdog/wm8350_wdt.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/watchdog/wm8350_wdt.c b/drivers/watchdog/wm8350_wdt.c > index 33c62d51f00a..911ad64460a6 100644 > --- a/drivers/watchdog/wm8350_wdt.c > +++ b/drivers/watchdog/wm8350_wdt.c > @@ -153,18 +153,11 @@ static int wm8350_wdt_probe(struct platform_device *pdev) > /* Default to 4s timeout */ > wm8350_wdt_set_timeout(&wm8350_wdt, 4); > > - return watchdog_register_device(&wm8350_wdt); > -} > - > -static int wm8350_wdt_remove(struct platform_device *pdev) > -{ > - watchdog_unregister_device(&wm8350_wdt); > - return 0; > + return devm_watchdog_register_device(&wm8350_wdt); > } > > static struct platform_driver wm8350_wdt_driver = { > .probe = wm8350_wdt_probe, > - .remove = wm8350_wdt_remove, > .driver = { > .name = "wm8350-wdt", > }, > -- > 2.39.1 >