On 3/6/23 01:15, Uwe Kleine-König wrote:
On Sat, Mar 04, 2023 at 08:56:53AM -0800, Guenter Roeck wrote:
Use devm_add_action_or_reset() to disable the watchdog when the driver
is removed to simplify the code. With this in place, we can use
devm_watchdog_register_device() to register the watchdog, and the removal
function is no longer necessary.
While the cleanup in this driver is good (
Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
) I wonder if disabling the watchdog at .remove() is right.
At least there is an inconsistency among watchdog drivers if the
hardware is supposed to stop or not.
Yes, it is, and it is one of those endless-argument things. Some driver
authors insist that the watchdog be stopped, some insist that it isn't.
That is why we have watchdog_stop_on_unregister().
Note I didn't use that here because the watchdog isn't stopped on unregister
but just disabled. That is slightly different, and I didn't want to change
functionality.
Guenter
