On Fri, Mar 03, 2023 at 10:37:11PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/watchdog/sa1100_wdt.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/watchdog/sa1100_wdt.c b/drivers/watchdog/sa1100_wdt.c
> index 82ac5d19f519..5d2df008b92a 100644
> --- a/drivers/watchdog/sa1100_wdt.c
> +++ b/drivers/watchdog/sa1100_wdt.c
> @@ -229,19 +229,17 @@ static int sa1100dog_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int sa1100dog_remove(struct platform_device *pdev)
> +static void sa1100dog_remove(struct platform_device *pdev)
> {
> misc_deregister(&sa1100dog_miscdev);
> clk_disable_unprepare(clk);
> clk_put(clk);
> -
> - return 0;
> }
>
> static struct platform_driver sa1100dog_driver = {
> .driver.name = "sa1100_wdt",
> .probe = sa1100dog_probe,
> - .remove = sa1100dog_remove,
> + .remove_new = sa1100dog_remove,
> };
> module_platform_driver(sa1100dog_driver);
>
> --
> 2.39.1
>
