On Fri, Mar 03, 2023 at 10:37:01PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/watchdog/nv_tco.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/watchdog/nv_tco.c b/drivers/watchdog/nv_tco.c
> index f6902a337422..ac4a9c16341d 100644
> --- a/drivers/watchdog/nv_tco.c
> +++ b/drivers/watchdog/nv_tco.c
> @@ -446,12 +446,10 @@ static void nv_tco_cleanup(void)
> release_region(tcobase, 0x10);
> }
>
> -static int nv_tco_remove(struct platform_device *dev)
> +static void nv_tco_remove(struct platform_device *dev)
> {
> if (tcobase)
> nv_tco_cleanup();
> -
> - return 0;
> }
>
> static void nv_tco_shutdown(struct platform_device *dev)
> @@ -469,7 +467,7 @@ static void nv_tco_shutdown(struct platform_device *dev)
>
> static struct platform_driver nv_tco_driver = {
> .probe = nv_tco_init,
> - .remove = nv_tco_remove,
> + .remove_new = nv_tco_remove,
> .shutdown = nv_tco_shutdown,
> .driver = {
> .name = TCO_MODULE_NAME,
> --
> 2.39.1
>
