On Fri, Mar 03, 2023 at 10:36:56PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/watchdog/ib700wdt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/ib700wdt.c b/drivers/watchdog/ib700wdt.c
> index a0ddedc362fc..39ea97009abd 100644
> --- a/drivers/watchdog/ib700wdt.c
> +++ b/drivers/watchdog/ib700wdt.c
> @@ -316,14 +316,13 @@ static int __init ibwdt_probe(struct platform_device *dev)
> return res;
> }
>
> -static int ibwdt_remove(struct platform_device *dev)
> +static void ibwdt_remove(struct platform_device *dev)
> {
> misc_deregister(&ibwdt_miscdev);
> release_region(WDT_START, 1);
> #if WDT_START != WDT_STOP
> release_region(WDT_STOP, 1);
> #endif
> - return 0;
> }
>
> static void ibwdt_shutdown(struct platform_device *dev)
> @@ -333,7 +332,7 @@ static void ibwdt_shutdown(struct platform_device *dev)
> }
>
> static struct platform_driver ibwdt_driver = {
> - .remove = ibwdt_remove,
> + .remove_new = ibwdt_remove,
> .shutdown = ibwdt_shutdown,
> .driver = {
> .name = DRV_NAME,
> --
> 2.39.1
>
