On Fri, Mar 03, 2023 at 10:36:54PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/watchdog/gef_wdt.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/watchdog/gef_wdt.c b/drivers/watchdog/gef_wdt.c
> index df5406aa7d25..97afc907f659 100644
> --- a/drivers/watchdog/gef_wdt.c
> +++ b/drivers/watchdog/gef_wdt.c
> @@ -283,15 +283,13 @@ static int gef_wdt_probe(struct platform_device *dev)
> return misc_register(&gef_wdt_miscdev);
> }
>
> -static int gef_wdt_remove(struct platform_device *dev)
> +static void gef_wdt_remove(struct platform_device *dev)
> {
> misc_deregister(&gef_wdt_miscdev);
>
> gef_wdt_handler_disable();
>
> iounmap(gef_wdt_regs);
> -
> - return 0;
> }
>
> static const struct of_device_id gef_wdt_ids[] = {
> @@ -308,7 +306,7 @@ static struct platform_driver gef_wdt_driver = {
> .of_match_table = gef_wdt_ids,
> },
> .probe = gef_wdt_probe,
> - .remove = gef_wdt_remove,
> + .remove_new = gef_wdt_remove,
> };
>
> static int __init gef_wdt_init(void)
> --
> 2.39.1
>
