On Fri, Mar 03, 2023 at 10:36:51PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/watchdog/bcm_kona_wdt.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/watchdog/bcm_kona_wdt.c b/drivers/watchdog/bcm_kona_wdt.c
> index 8237c4e9c2a0..49e12d47b073 100644
> --- a/drivers/watchdog/bcm_kona_wdt.c
> +++ b/drivers/watchdog/bcm_kona_wdt.c
> @@ -310,12 +310,10 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int bcm_kona_wdt_remove(struct platform_device *pdev)
> +static void bcm_kona_wdt_remove(struct platform_device *pdev)
> {
> bcm_kona_wdt_debug_exit(pdev);
> dev_dbg(&pdev->dev, "Watchdog driver disabled");
> -
> - return 0;
> }
>
> static const struct of_device_id bcm_kona_wdt_of_match[] = {
> @@ -330,7 +328,7 @@ static struct platform_driver bcm_kona_wdt_driver = {
> .of_match_table = bcm_kona_wdt_of_match,
> },
> .probe = bcm_kona_wdt_probe,
> - .remove = bcm_kona_wdt_remove,
> + .remove_new = bcm_kona_wdt_remove,
> };
>
> module_platform_driver(bcm_kona_wdt_driver);
> --
> 2.39.1
>
