On Fri, Mar 03, 2023 at 10:36:48PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/watchdog/ath79_wdt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/ath79_wdt.c b/drivers/watchdog/ath79_wdt.c
> index 0f18f06a21b6..b7b705060438 100644
> --- a/drivers/watchdog/ath79_wdt.c
> +++ b/drivers/watchdog/ath79_wdt.c
> @@ -296,11 +296,10 @@ static int ath79_wdt_probe(struct platform_device *pdev)
> return err;
> }
>
> -static int ath79_wdt_remove(struct platform_device *pdev)
> +static void ath79_wdt_remove(struct platform_device *pdev)
> {
> misc_deregister(&ath79_wdt_miscdev);
> clk_disable_unprepare(wdt_clk);
> - return 0;
> }
>
> static void ath79_wdt_shutdown(struct platform_device *pdev)
> @@ -318,7 +317,7 @@ MODULE_DEVICE_TABLE(of, ath79_wdt_match);
>
> static struct platform_driver ath79_wdt_driver = {
> .probe = ath79_wdt_probe,
> - .remove = ath79_wdt_remove,
> + .remove_new = ath79_wdt_remove,
> .shutdown = ath79_wdt_shutdown,
> .driver = {
> .name = DRIVER_NAME,
> --
> 2.39.1
>
