On Fri, Mar 03, 2023 at 10:36:45PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/watchdog/advantechwdt.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/watchdog/advantechwdt.c b/drivers/watchdog/advantechwdt.c
> index 554fe85da50e..7a0acbc3e4dd 100644
> --- a/drivers/watchdog/advantechwdt.c
> +++ b/drivers/watchdog/advantechwdt.c
> @@ -279,14 +279,12 @@ static int __init advwdt_probe(struct platform_device *dev)
> goto out;
> }
>
> -static int advwdt_remove(struct platform_device *dev)
> +static void advwdt_remove(struct platform_device *dev)
> {
> misc_deregister(&advwdt_miscdev);
> release_region(wdt_start, 1);
> if (wdt_stop != wdt_start)
> release_region(wdt_stop, 1);
> -
> - return 0;
> }
>
> static void advwdt_shutdown(struct platform_device *dev)
> @@ -296,7 +294,7 @@ static void advwdt_shutdown(struct platform_device *dev)
> }
>
> static struct platform_driver advwdt_driver = {
> - .remove = advwdt_remove,
> + .remove_new = advwdt_remove,
> .shutdown = advwdt_shutdown,
> .driver = {
> .name = DRV_NAME,
> --
> 2.39.1
>
