On 01/03/2023 18:52, Srinivas Neeli wrote: > Versal watchdog driver uses window watchdog mode. Window watchdog > timer(WWDT) contains closed(first) and open(second) window with > 32 bit width. Write to the watchdog timer within predefined window > periods of time. This means a period that is not too soon and > a period that is not too late. > > Updated devicetree bindings for adding versal window watchdog device. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xxxxxxx> > --- > Changes in V2: > - Added watchdog ref > - Removed timeout-sec property > - Used 4 spaces for example indentation. > --- > .../bindings/watchdog/xlnx,versal-wwdt.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > new file mode 100644 > index 000000000000..733de1ac60e8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/xlnx,versal-wwdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx Versal window watchdog timer controller > + > +maintainers: > + - Neeli Srinivas <srinivas.neeli@xxxxxxx> > + > +description: > + Versal watchdog driver uses window watchdog mode. Window watchdog > + timer(WWDT) contains closed(first) and open(second) window with > + 32 bit width. Write to the watchdog timer within predefined window > + periods of time. This means a period that is not too soon and a > + period that is not too late. The WWDT has to be restarted within > + the open window time. If software tries to restart WWDT outside of > + the open window time period, it generates a reset. > + > +allOf: > + - $ref: /schemas/watchdog/watchdog.yaml# > + > +properties: > + compatible: > + enum: > + - xlnx,versal-wwdt > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + xlnx,close_percent: > + $ref: "/schemas/types.yaml#/definitions/uint32" > + minimum: 1 > + maximum: 99 > + default: 50 > + description: closed window percentage There was no such property before and your changelog does not explain it. Don't add new stuff silently in new versions. There are several issues with this - missing dscription (you just copied name of property!), unneeded quotes, using underscore, incorrect name suffix... but what's the most important - what is the justification to put it into DT? IOW, why this is suitable for DT? Best regards, Krzysztof
