Re: [PATCH -next] watchdog: diag288_wdt: use kmemdup() to allocate memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 02, 2023 at 05:35:40AM -0800, Guenter Roeck wrote:
> On 2/2/23 05:22, Heiko Carstens wrote:
> > On Thu, Feb 02, 2023 at 03:41:27PM +0800, Yang Yingliang wrote:
> > > Use kmemdup() helper instead of open-coding to simplify
> > > the code when allocating ebc_cmd.
> > > 
> > > Generated by: scripts/coccinelle/api/memdup.cocci
> > > 
> > > Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> > > ---
> > >   drivers/watchdog/diag288_wdt.c | 3 +--
> > >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > Thanks, but this code will be changed differently with the next merge
> > window. Therefore I will not apply patch.
> 
> It looks like you decided to bypass even sending your patches to the watchdog
> mailing list. I know I have not been as responsive there as I should be,
> but that it no reason to bypass the maintainers completely.

This is s390 only code which is broken. I doubt that anybody cares
about s390 specific inline assemblies.

But yes, besides that you are correct.



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux