On Fri, Oct 28, 2022 at 09:27:50AM +0300, Mika Westerberg wrote:
> Daniel reported that the commit 1ae3e78c0820 ("watchdog: iTCO_wdt: No
> need to stop the timer in probe") makes QEMU implementation of the iTCO
> watchdog not to trigger reboot anymore when NO_REBOOT flag is initially
> cleared using this option (in QEMU command line):
>
> -global ICH9-LPC.noreboot=false
>
> The problem with the commit is that it left the unconditional setting of
> NO_REBOOT that is not cleared anymore when the kernel keeps pinging the
> watchdog (as opposed to the previous code that called iTCO_wdt_stop()
> that cleared it).
>
> Fix this so that we only set NO_REBOOT if the watchdog was not initially
> running.
>
> Fixes: 1ae3e78c0820 ("watchdog: iTCO_wdt: No need to stop the timer in probe")
> Reported-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Tested-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
