On 10/17/22 06:08, Thomas Kastner wrote:
On Mon, Oct 17, 2022 at 05:24:07AM -0700, Guenter Roeck wrote:
Please drop "drivers:" and the driver name from the subject,
version your patches, and provide change logs.
Also, please fix the following problems reported by checkpatch.
Thanks for your patience.
Can you please confirm the version of checkpatch or any parameters used?
I'm using v0.32 which seems to be the latest in GKH's staging tree as
well as Linus' mainline. It has just given me the quoted string warning,
but not the others as below- although of course those are valid.
Just trying to get to the same result...
No questions on the other items, Will implement the changes and provide
a versioned v3 with change notes later.
CHECK is only reported if checkpatch.pl --strict is used.
Guenter
CHECK: Alignment should match open parenthesis
#144: FILE: drivers/watchdog/advantech_ec_wdt.c:55:
+MODULE_PARM_DESC(timeout,
+ "Default Watchdog timer setting ("
WARNING: quoted string split across lines
#146: FILE: drivers/watchdog/advantech_ec_wdt.c:57:
+ __MODULE_STRING(DEFAULT_TIME) "s)."
+ "The range is from " __MODULE_STRING(MIN_TIME)
CHECK: Please don't use multiple blank lines
#270: FILE: drivers/watchdog/advantech_ec_wdt.c:181:
