On 7/1/22 10:18, Rob Herring wrote:
On Wed, Jun 29, 2022 at 01:06:26PM +0200, Isaac True wrote:
Add the "min_hw_margin_ms" parameter to gpio_wdt devices, allowing a
minimum interval to be specified, stopping watchdog devices from being
fed too quickly if they require a certain interval between feeds.
I assume there is some real platform with a real problem you are trying
to solve? Details please.
Agreed, this should be explained in more detail.
Can you just hardcode some min? Maybe 10% of the max or something. Is
there a downside to a larger than necessary min?
That would result in extra overhead in the watchdog core which would not
be required for all other hardware using this driver. I'd rather avoid that.
Wouldn't be better to fix this without requiring a DT change and that
could work on stable kernels if needed.
Presumably that is some new hardware. Most of the watchdog drivers
needing this value can derive it from the compatible property. The
gpio watchdog driver is a bit different since it is supposed to work
on a variety of hardware using gpio pins for watchdog control.
Guenter
