On Tue, 21 Jun 2022 07:08:25 -0700, Guenter Roeck wrote: > On Tue, Jun 21, 2022 at 03:28:40PM +0200, Jean Delvare wrote: > > Unlike release_mem_region(), a call to release_resource() does not > > free the resource, so it has to be freed explicitly to avoid a memory > > leak. > > > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> > > Fixes: 0578fff4aae5 ("Watchdog: sp5100_tco: Add initialization using EFCH MMIO") > > Cc: Terry Bowman <terry.bowman@xxxxxxx> > > Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx> > > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> Thanks. > Unless I am missing something, it looks like every caller of > request_mem_region_muxed() has that problem. You are correct. Fixes have been sent for review already. -- Jean Delvare SUSE L3 Support